perf: dynamic cross-block cache size #15872
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zitup
requested review from
Rjected,
fgimenez,
gakonst,
mattsse and
rkrasiuk
as code owners
0xalpharush
reviewed
Apr 30, 2025
Comment on lines
+30
to
+32
| let total_memory = sys.total_memory(); | ||
| let used_memory = sys.used_memory(); | ||
| let available_memory = total_memory - used_memory; |
Contributor
There was a problem hiding this comment.
This calculation is redundant. Use https://docs.rs/sysinfo/latest/sysinfo/struct.System.html#method.available_memory
github-actions
bot
added
the
S-stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15802