fix: update AllTransactions metrics on removals and evictions #19832
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattsse
reviewed
Nov 18, 2025
Collaborator
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
this makes sense in general, but I don't think we need all the additional calls then?
| ] | ||
| ); | ||
|
|
||
| self.update_size_metrics(); |
Collaborator
There was a problem hiding this comment.
we shouldn't do this here because there's no need to update the metrics here
| self.metrics.blob_pool_transactions.set(stats.blob as f64); | ||
| self.metrics.blob_pool_size_bytes.set(stats.blob_size as f64); | ||
| self.metrics.total_transactions.set(stats.total as f64); | ||
| self.all_transactions.update_size_metrics(); |
Collaborator
There was a problem hiding this comment.
if we add this here, why do we need to also call this in the other locations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AllTransactions metrics were updated on inserts but could remain stale after removals and evictions. Several removal paths invoked only TxPool::update_size_metrics, which updates sub-pool gauges but not AllTransactions gauges, and discard_worst did not update metrics at all. This change makes TxPool::update_size_metrics also refresh AllTransactions metrics, invokes update_size_metrics at the end of discard_worst, and updates AllTransactions metrics inside its removal methods. The result is consistent metrics for both sub-pools and the AllTransactions set across insertion, removal, and eviction flows without relying on incidental future inserts to refresh gauges. Tests cover remove-by-hash and eviction flows.