Skip to content

fix: use correct dictionary in create_tx_compressor #19840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: use correct dictionary in create_tx_compressor #19840

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions crates/storage/zstd-compressors/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,9 @@ pub static TRANSACTION_DICTIONARY: &[u8] = include_bytes!("../transaction_dictio
pub use locals::*;
#[cfg(feature = "std")]
mod locals {
use super::*;
use super::{
Compressor, Decompressor, ReusableDecompressor, RECEIPT_DICTIONARY, TRANSACTION_DICTIONARY,
};
use core::cell::RefCell;

// We use `thread_local` compressors and decompressors because dictionaries can be quite big,
Expand Down Expand Up @@ -58,26 +60,27 @@ mod locals {
}
}

/// Fn creates tx [`Compressor`]
/// Creates a transaction [`Compressor`] with the appropriate dictionary.
pub fn create_tx_compressor() -> Compressor<'static> {
Compressor::with_dictionary(0, RECEIPT_DICTIONARY).expect("Failed to instantiate tx compressor")
Compressor::with_dictionary(0, TRANSACTION_DICTIONARY)
.expect("Failed to instantiate tx compressor")
}

/// Fn creates tx [`Decompressor`]
/// Creates a transaction [`Decompressor`] with the appropriate dictionary.
pub fn create_tx_decompressor() -> ReusableDecompressor {
ReusableDecompressor::new(
Decompressor::with_dictionary(TRANSACTION_DICTIONARY)
.expect("Failed to instantiate tx decompressor"),
)
}

/// Fn creates receipt [`Compressor`]
/// Creates a receipt [`Compressor`] with the appropriate dictionary.
pub fn create_receipt_compressor() -> Compressor<'static> {
Compressor::with_dictionary(0, RECEIPT_DICTIONARY)
.expect("Failed to instantiate receipt compressor")
}

/// Fn creates receipt [`Decompressor`]
/// Creates a receipt [`Decompressor`] with the appropriate dictionary.
pub fn create_receipt_decompressor() -> ReusableDecompressor {
ReusableDecompressor::new(
Decompressor::with_dictionary(RECEIPT_DICTIONARY)
Expand Down