chore(ethereum): avoid cloning requests in try_into_v4 #19851
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes an unnecessary clone of the execution requests in EthBuiltPayload::try_into_v4 by switching to Option::take and passing ownership directly into ExecutionPayloadEnvelopeV4. The previous implementation cloned self.requests even though self is immediately consumed by try_into for the inner V3 envelope, leading to avoidable allocations and copies for potentially large alloy_eips::eip7685::Requests. The new approach mirrors try_into_v5 which already moves requests without cloning, keeps the conversion logic centralized by still delegating to try_into_v3 for envelope_inner, and preserves all semantics while improving performance.