feat: add eth_getAddressesInBlock RPC method #19858
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xChaddB
requested review from
Rjected,
RomanHodulak and
mattsse
as code owners
mattsse
requested changes
Nov 19, 2025
Comment on lines
+243
to
+245
| use reth_primitives_traits::SignerRecoverable; | ||
| for tx in block.body().transactions() { | ||
| if let Ok(signer) = tx.recover_signer() { |
Collaborator
There was a problem hiding this comment.
this should already be recovered so we can iterate over
reth/crates/primitives-traits/src/block/recovered.rs
Lines 341 to 345 in 819330c
Comment on lines
+210
to
+232
|
|
||
| if block_id.is_pending() { | ||
| return Ok(Vec::new()); | ||
| } | ||
|
|
||
| let block_hash = match self | ||
| .provider() | ||
| .block_hash_for_id(block_id) | ||
| .map_err(|e| reth_rpc_eth_types::EthApiError::Internal(e.into()))? | ||
| { | ||
| Some(hash) => hash, | ||
| None => return Ok(Vec::new()), | ||
| }; | ||
|
|
||
| let block = match self | ||
| .cache() | ||
| .get_recovered_block(block_hash) | ||
| .await | ||
| .map_err(|e| reth_rpc_eth_types::EthApiError::Internal(e.into()))? | ||
| { | ||
| Some(block) => block, | ||
| None => return Ok(Vec::new()), | ||
| }; |
Collaborator
There was a problem hiding this comment.
I believe this should already be just
| let db = StateProviderDatabase::new(&state_provider); | ||
| let block_executor = this.evm_config().executor(db); | ||
|
|
||
| let mut record = ExecutionWitnessRecord::default(); |
Collaborator
There was a problem hiding this comment.
I don't think we need this here and can instead take a look at the full state output and iterate over the accounts in there
Comment on lines
+280
to
+297
| use alloy_primitives::keccak256; | ||
| for key_bytes in &witness_record.keys { | ||
| // Only consider 20-byte entries as potential addresses | ||
| if key_bytes.len() == 20 && | ||
| let Ok(address_bytes) = <[u8; 20]>::try_from(&key_bytes[..]) | ||
| { | ||
| let address = Address::from(address_bytes); | ||
| let hashed_addr = keccak256(address.as_slice()); | ||
| let hash_b256 = alloy_primitives::B256::from(hashed_addr); | ||
|
|
||
| // Validate this is actually an account by checking if its hash exists in | ||
| // hashed_state This removes false positives while not | ||
| // relying on private fields | ||
| if witness_record.hashed_state.accounts.contains_key(&hash_b256) { | ||
| set.insert(address); | ||
| } | ||
| } | ||
| } |
Collaborator
There was a problem hiding this comment.
then we don't need any of this
Comment on lines
+299
to
+305
| let Some(receipts) = self | ||
| .provider() | ||
| .receipts_by_block_id(block_id) | ||
| .map_err(|e| reth_rpc_eth_types::EthApiError::Internal(e.into()))? | ||
| else { | ||
| return Ok(set.into_iter().collect()); | ||
| }; |
Collaborator
There was a problem hiding this comment.
we can use
to fetch both block and receipts
Comment on lines
+455
to
+457
| pub trait EthAddresses: LoadState<Error: FromEvmError<Self::Evm>> { | ||
| /// Returns the list of addresses that appeared in the given block. | ||
| async fn get_addresses_in_block( |
Collaborator
There was a problem hiding this comment.
any ideas where we can best integrate this @klkvr
perhaps simply in the Trace api?
mattsse
added
C-enhancement
Member
|
yeah I think An address MAY appear in any of the following:
Note that the call tracer "to", "from", "input" and "output" fields are sufficient to capture all |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new method
eth_getAddressesInBlockthat returns all unique addresses that appear in a given block.Implementation:
EthAddressestrait added toFullEthApiFixes #19610