fix: disable state root task when no changesets #19869
Closed
+14
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rjected
requested review from
fgimenez,
mattsse,
mediocregopher and
yongkangc
as code owners
yongkangc
approved these changes
Nov 20, 2025
Member
yongkangc
left a comment
yongkangc
left a comment
There was a problem hiding this comment.
Changes makes sense to me
Why is it not safe to run without change sets? Or what might be the case that it doesn't work
Rjected
force-pushed
the
dan/fix-error-zero-merkle-changesets
branch
from
16e4d47 to
3315a55
Compare
Member
Author
Because the DB might move between two db tx creations, in the case of a reorg this can lead to a situation where we can no longer get the correct trie state, for example the bugs that led to the creation of trie changesets in the first place |
Rjected
force-pushed
the
dan/fix-error-zero-merkle-changesets
branch
from
3315a55 to
8e3e5ba
Compare
Member
Author
|
fixed clippy |
shekhirin
reviewed
Nov 20, 2025
Co-authored-by: Alexey Shekhirin <[email protected]>
shekhirin
approved these changes
Nov 20, 2025
Collaborator
shekhirin
left a comment
shekhirin
left a comment
There was a problem hiding this comment.
LGTM, @mediocregopher please take a look
Member
Author
|
closing, I think this is a bit of an edge case that we can continue to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not safe to run the state root task or parallel state root anyways if there are not merkle changesets, so we disable it when we have no merkle changesets