Skip to content

Conversation

@Fibonacci747
Copy link
Contributor

The builder in NetworkArgs::network_config() previously called peer_config twice, where the second assignment rebuilt PeersConfig from a raw clone and overwrote the config that had already included basic nodes from the peers file via peers_config_with_basic_nodes_from_file, resulting in persisted peers being dropped on startup. This change composes peers_config from the file-enriched configuration first, then applies inbound/outbound and IP filter overrides, and sets peer_config only once so persisted peers are preserved as documented. The unit test ensures a NodeRecord present in a temporary peers file is included in the final NetworkConfig’s peers_config.basic_nodes. The test also uses reth_network::EthNetworkPrimitives to avoid an unresolved crate, and a redundant clone warning in network_config was addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Backlog

Development

Successfully merging this pull request may close these issues.

1 participant