Skip to content

fix(storage): buffer advancement in Compact::from_compact for alloy wrappers #19899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(storage): buffer advancement in Compact::from_compact for alloy wrappers #19899

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
932babe
return the advanced slice from Withdrawal::from_compact
Snezhkko Nov 21, 2025
6780d35
return the advanced slice from GenesisAccount::from_compact
Snezhkko Nov 21, 2025
a1f4619
return the advanced slice from Header::from_compact
Snezhkko Nov 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions crates/storage/codecs/src/alloy/genesis_account.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ impl Compact for AlloyGenesisAccount {
}

fn from_compact(buf: &[u8], len: usize) -> (Self, &[u8]) {
let (account, _) = GenesisAccount::from_compact(buf, len);
let (account, new_buf) = GenesisAccount::from_compact(buf, len);
let alloy_account = Self {
nonce: account.nonce,
balance: account.balance,
Expand All @@ -102,6 +102,6 @@ impl Compact for AlloyGenesisAccount {
.map(|s| s.entries.into_iter().map(|entry| (entry.key, entry.value)).collect()),
private_key: account.private_key,
};
(alloy_account, buf)
(alloy_account, new_buf)
}
}
4 changes: 2 additions & 2 deletions crates/storage/codecs/src/alloy/header.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ impl Compact for AlloyHeader {
}

fn from_compact(buf: &[u8], len: usize) -> (Self, &[u8]) {
let (header, _) = Header::from_compact(buf, len);
let (header, new_buf) = Header::from_compact(buf, len);
let alloy_header = Self {
parent_hash: header.parent_hash,
ommers_hash: header.ommers_hash,
Expand All @@ -134,7 +134,7 @@ impl Compact for AlloyHeader {
requests_hash: header.extra_fields.as_ref().and_then(|h| h.requests_hash),
extra_data: header.extra_data,
};
(alloy_header, buf)
(alloy_header, new_buf)
}
}

Expand Down
4 changes: 2 additions & 2 deletions crates/storage/codecs/src/alloy/withdrawal.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,14 +43,14 @@ impl Compact for AlloyWithdrawal {
}

fn from_compact(buf: &[u8], len: usize) -> (Self, &[u8]) {
let (withdrawal, _) = Withdrawal::from_compact(buf, len);
let (withdrawal, new_buf) = Withdrawal::from_compact(buf, len);
let alloy_withdrawal = Self {
index: withdrawal.index,
validator_index: withdrawal.validator_index,
address: withdrawal.address,
amount: withdrawal.amount,
};
(alloy_withdrawal, buf)
(alloy_withdrawal, new_buf)
}
}

Expand Down
Loading