feat(op): pull chain config from superchain-registry github #19914
+44
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xPenryn
requested review from
Rjected,
fgimenez,
gakonst and
mattsse
as code owners
Collaborator
|
is it really needed to wait for new release to pull the latest registry now? isn't it just a matter of replacing the json file on the specific path manually? agree though that it's cooler if this is done automatically. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the
reth-optimism-chainspeccrate, adding functionality to pull the latest chain configuration directly from the superchain registry. If the superchain registry is unreachable, it will fall back to the local chain configurations and follow the existing behavior.This means that op-reth doesn't need to cut a new release to reflect updates to the superchain registry; rather, the node operator simply needs to restart op-reth and it will pull the latest config.