feat(storage): log storage settings on startup #19931
Open
+13
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shekhirin
added
C-enhancement
joshieDo
approved these changes
Nov 24, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
mattsse
requested changes
Nov 24, 2025
Collaborator
mattsse
left a comment
mattsse
left a comment
There was a problem hiding this comment.
what if we log this here instead?
reth/crates/node/builder/src/launch/engine.rs
Lines 99 to 102 in e03c9da
| .storage_settings()? | ||
| .unwrap_or(legacy_settings); | ||
| .storage_settings()?; | ||
| let storage_settings = Arc::new(RwLock::new(stored_settings.unwrap_or(legacy_settings))); |
Collaborator
There was a problem hiding this comment.
this change is a bit weird, why move the arc rwlock to here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2025-11-24T09:59:31.281131Z INFO Storage settings legacy=StorageSettings { receipts_in_static_files: false, transaction_senders_in_static_files: false } stored=Some(StorageSettings { receipts_in_static_files: false, transaction_senders_in_static_files: false }) current=StorageSettings { receipts_in_static_files: false, transaction_senders_in_static_files: false }