fix(transaction-pool): Spawn ValidationTask to keep channel open #19943
+59
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In crates/transaction-pool/src/validate/task.rs, the constructor TransactionValidationTaskExecutor::new() previously created the channel ValidationTask::new () channel and immediately lost the receiver without running ValidationTask::run(), which caused the channel to close and all send() calls to end with ValidationServiceUnreachable; now we save the receiver and immediately start the background runner via tokio::task::spawn(async move { task.run().await; }), so the validator actually consumes and executes tasks, and validation calls start working, and we added regression tests at the end of task.rs, which confirmed correctness after the fix.