perf: spawn storage root tasks in parallel #20585
Open
+34
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lorsmirq0cB
requested review from
Rjected,
mediocregopher and
shekhirin
as code owners
crates/trie/parallel/src/root.rs
Outdated
| }); | ||
|
|
||
| // Insert all receivers into the storage_roots map | ||
| for (hashed_address, rx) in receivers { |
Collaborator
There was a problem hiding this comment.
Is this intermediate receives Vec necessary? Could we instead insert directly into storage_roots in the for-loop above?
Lorsmirq0cB
requested review from
joshieDo,
klkvr,
mattsse and
rakita
as code owners
Lorsmirq0cB
force-pushed
the
parallel-spawn
branch
2 times, most recently
from
08ec6c3 to
3220ad1
Compare
Lorsmirq0cB
force-pushed
the
parallel-spawn
branch
from
143098c to
e314970
Compare
Contributor
Author
|
@mediocregopher , Good point! Much cleaner this way. Updated, please let me know if you see any other improvements needed. Thanks for the feedback! |
mediocregopher
approved these changes
Dec 24, 2025
Collaborator
|
cc @yongkangc |
Member
|
Does this improve sparse trie / work we are optimizing rn Brian? Or is it mostly for fallback code? |
Collaborator
@gakonst this is in the legacy state root code path, won't affect the sparse trie |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spawns storage root calculation tasks in parallel instead of serially, reduces task initialization overhead.