fix(ipc): trim leading whitespace in StreamCodec decode #20615
+7
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Trim leading whitespace from decoded JSON-RPC messages in
StreamCodec, resolving a TODO and improving IPC message handling.Problem
When
StreamCodec::decode()parses JSON-RPC messages over IPC, it includes leading whitespace (newlines, tabs, spaces) that appears between messages. This is unnecessary since:start_idxvariable already tracks where JSON actually begins, but was not being used to discard prior bytesBefore
After
User Benefits
{or[Changes
stream_codec.rs: Discard bytes beforestart_idxindecode()whitespacetest expectationshugetest to start with{directly