feat(trie): Add flag to enable proof v2 for storage proof workers #20617
+449
−228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…6-proof-rewrite-partial-proofs
…4-proof-rewrite-storage-workers
…4-proof-rewrite-storage-workers
mediocregopher
commented
Dec 23, 2025
| @@ -621,11 +625,6 @@ | |||
| } | |||
| } | |||
Collaborator
Author
There was a problem hiding this comment.
clippy complained this isn't used anymore, even though it was used in the tests. I just inlined the tx.clone() in the tests instead.
mediocregopher
requested review from
Rjected,
fgimenez,
gakonst,
klkvr,
mattsse,
shekhirin and
yongkangc
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #19514
--engine.enable-proof-v2is added.StorageProofInputtype is made into an enum with a Legacy and V2 variant, so the storage proof workers can serve either kind of request.StorageProofInputto use.proof_v2::StorageProofCalculatorduring their startup, and have it available for calculatingStorageProofInput::V2s.StorageProofResultis introduced, which functions similarly toStorageProofInput. The account workers will convert either variant ofStorageProofResultto aDecodedMultiProof. Once account workers also support V2 proofs this step won't be necessary.