feat(engine/metrics): add latest valid fcu #20628
Open
+36
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
figtracer
requested review from
Rjected,
fgimenez,
mattsse,
mediocregopher and
yongkangc
as code owners
Rjected
requested changes
Dec 24, 2025
Member
Rjected
left a comment
Rjected
left a comment
There was a problem hiding this comment.
Should have specified this better in the issue, but I don't think it's useful to have the hash bits as a gauge. We should instead have a number for the latest valid fcu head / safe / finalized
Contributor
Author
on it |
Contributor
Author
|
this will run if fcu is invalid as well, but ig it's not that relevant |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#20621