fix(refactor): skip transient selfdestruct storage wipes#26433
Draft
mediocregopher wants to merge 7 commits into
Draft
fix(refactor): skip transient selfdestruct storage wipes#26433mediocregopher wants to merge 7 commits into
mediocregopher wants to merge 7 commits into
Conversation
mediocregopher
added
A-trie
mediocregopher
changed the title
Member
Author
|
cyclops audit |
Contributor
|
Cyclops audit event published. View workflow run Config: config: |
Member
Author
|
cyclops audit |
Contributor
|
Cyclops audit event published. View workflow run Config: config: |
Member
👁️ Cyclops Security Review
❌ Workflow failed · no review posted Cyclops failed before it could finish the PR review. This status was repaired by the workflow exit handler.
No Cyclops review was posted for this run. |
…-transient-selfdestruct-wipes # Conflicts: # crates/trie/parallel/src/state_root_task.rs
Member
Author
|
cyclops audit |
Contributor
|
Cyclops audit event failed to publish. View workflow run Config: config: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevents streamed hashed-state conversion from emitting a storage wipe when an account is created and self-destructed in the same transaction. Such an account has no prior storage update to clear, and we don't want to support wipes in the engine live-sync code paths.