feat(storage-api): add consuming state root variant#26442
Open
0xMars42 wants to merge 1 commit into
Open
Conversation
0xMars42
requested review from
Rjected,
joshieDo,
mattsse and
mediocregopher
as code owners
July 19, 2026 17:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17998.
Adds
StateRootProvider::state_root_with_updates_consumed, aself: Box<Self>variant with a default that delegates to the borrowing version, so no existing implementation changes behavior.MemoryOverlayStateProviderand itsRefoverride it to move the cachedTrieInputinto the computation instead of cloning the aggregate of every in-memory block, and the engine's synchronous and serial-fallback state root jobs now call it on the provider they were about to drop.This removes the second full copy made on every such computation; the first one (aggregating the per-block sorted state into the cached input) remains. The block builder path in
BasicBlockBuilder::finishstill clones, since the provider is borrowed by the execution database and reused by the assembler there: consuming it needs an ownership restructuring left for a follow-up, as are the proof and witness paths.