feat(cli): honor --gas-limit for path/custom bytecode fixtures#405
Open
cuiweixie wants to merge 2 commits into
Open
feat(cli): honor --gas-limit for path/custom bytecode fixtures#405cuiweixie wants to merge 2 commits into
cuiweixie wants to merge 2 commits into
Conversation
Wire the existing CLI flag into fixture_from_bytecode so ad-hoc runs no longer hardcode i64::MAX for block and tx gas limits.
gas_limit is already hex-prefixed; using :x on the String would not compile.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--gas-limitintofixture_from_bytecodefor path and custom (hex/asm) inputs.currentGasLimitand transactiongasLimitfrom that value instead of hardcoding0x7fffffffffffffff.Test plan
cargo r -- run 0x6001600201 --gas-limit 100000runs successfully--gas-limituses the default (1000000000)cargo r -- run usdc_proxy) still works as before