Skip to content

feat(sema): integer explicit conversions #633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mablr wants to merge 4 commits into
base: main
Choose a base branch
from
Open

feat(sema): integer explicit conversions #633

mablr wants to merge 4 commits into from

Conversation

@mablr
Copy link
Contributor

@mablr mablr commented Dec 13, 2025

Closes #611

  • Introduced integer explicit conversions
  • Added tests

Follows Solidity 0.8.0+ rules regarding type conversions (see https://docs.soliditylang.org/en/latest/080-breaking-changes.html#new-restrictions)

@mablr
feat(sema): integer explicit conversions
29d72b5 
- Added tests
- Follows Solidity 0.8.0+ rules regarding type conversions.
@mablr mablr marked this pull request as ready for review December 13, 2025 17:27
@mablr mablr marked this pull request as draft December 13, 2025 17:49
@mablr mablr marked this pull request as ready for review December 13, 2025 20:38
DaniPopes
DaniPopes reviewed Dec 13, 2025
View reviewed changes
@onbjerg onbjerg added C-enhancement Category: an issue proposing an enhancement or a PR with one A-sema Area: semantic analysis labels Dec 15, 2025
@mablr mablr marked this pull request as draft December 15, 2025 23:16
@onbjerg onbjerg mentioned this pull request Dec 17, 2025
Closed
@onbjerg
Copy link
Contributor

onbjerg commented Dec 17, 2025

I'm going to mark this blocked by #650 (see above discussion).

@onbjerg onbjerg added the S-blocked Status: this cannot more forward until something else changes label Dec 17, 2025
@onbjerg
Copy link
Contributor

onbjerg commented Dec 22, 2025

Hi @mablr, this is no longer blocked, see #671

@onbjerg onbjerg removed the S-blocked Status: this cannot more forward until something else changes label Dec 22, 2025
mablr
mablr commented Dec 23, 2025
View reviewed changes
Copy link
Contributor Author

@mablr mablr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mablr, this is no longer blocked, see #671

Thanks @onbjerg, i'll finish it soon.

@mablr mablr marked this pull request as ready for review December 23, 2025 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DaniPopes DaniPopes DaniPopes left review comments

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

+1 more reviewer

@dipanshuhappy dipanshuhappy dipanshuhappy left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

A-sema Area: semantic analysis C-enhancement Category: an issue proposing an enhancement or a PR with one

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Integer explicit conversions

4 participants

@mablr @onbjerg @DaniPopes @dipanshuhappy