Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
gakonst
reviewed
Jan 26, 2026
Member
gakonst
left a comment
gakonst
left a comment
There was a problem hiding this comment.
Nice - we should also give this another shot on Reth / tempo
DaniPopes
force-pushed
the
dani/pgo
branch
3 times, most recently
from
5f12969 to
bcfb5b2
Compare
Add PGO (Profile-Guided Optimization) to cargo-dist release workflow: - .github/scripts/build-pgo.sh: Uses cargo-pgo to build instrumented binary, gather profiles from testdata/*.sol, and set RUSTFLAGS - .github/workflows/dist-build-setup.yml: Runs PGO script before dist - .github/workflows/test-pgo-bolt.yml: Test workflow that builds baseline/PGO/PGO+BOLT binaries and benchmarks with hyperfine The test workflow also includes BOLT optimization which provides additional ~1% speedup on top of PGO's ~7% improvement. BOLT is not yet integrated into the release workflow as it requires post-build processing that cargo-dist doesn't support via hooks. Benchmark results (GitHub Actions runner): - Small files: PGO+BOLT is 8% faster than baseline - Large files: PGO+BOLT is 8% faster than baseline Co-authored-by: Amp <amp@ampcode.com> Amp-Thread-ID: https://ampcode.com/threads/T-019bf7a1-0015-74f4-a5f6-c71ce48b4663
Amp-Thread-ID: https://ampcode.com/threads/T-019bfaad-39e4-7636-a853-0c3e7b08d2c9 Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-019bfaad-39e4-7636-a853-0c3e7b08d2c9 Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-019bfaad-39e4-7636-a853-0c3e7b08d2c9 Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-019bfaad-39e4-7636-a853-0c3e7b08d2c9 Co-authored-by: Amp <amp@ampcode.com>
- Run build-pgo-bolt.sh before dist build for x86_64-linux-gnu - Replace binary in tarball with BOLT-optimized version after dist build - Add allow-dirty = ["ci"] to preserve manual release.yml edits - Re-add test-pgo-bolt.yml workflow Amp-Thread-ID: https://ampcode.com/threads/T-019bfaad-39e4-7636-a853-0c3e7b08d2c9 Co-authored-by: Amp <amp@ampcode.com>
- Add build-binaries.yml reusable workflow for all targets - Enable PGO+BOLT for x86_64-unknown-linux-gnu - Use build-local-artifacts=false + local-artifacts-jobs - cargo-dist now calls our workflow instead of its own build job - No manual release.yml modifications needed Amp-Thread-ID: https://ampcode.com/threads/T-019bfaad-39e4-7636-a853-0c3e7b08d2c9 Co-authored-by: Amp <amp@ampcode.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
needs upstream support in cargo-dist