Skip to content

Make witness generation conform to draft specs #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jsign wants to merge 23 commits into
base: main
Choose a base branch
from
Open

Make witness generation conform to draft specs #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
762348a
feat: add ef-test-runner for executing test suites
jsign Feb 13, 2026
4c5f7d3
feat: add Prague to Osaka fork specification in ForkSpec enum
jsign Feb 13, 2026
65594e9
all fixes
jsign Feb 16, 2026
b4c467c
refactor: simplify assert_matches method in FixtureExecutionWitness s…
jsign Feb 17, 2026
78ae37e
testing/runner: add support for remote .tar.gz bundle
jsign Feb 17, 2026
7fe7493
ci: add execution witness test check
jsign Feb 17, 2026
fd4e9d1
cargo: add temp reth patching
jsign Feb 17, 2026
5a2e472
update to latest reth pr commit
jsign Feb 17, 2026
3b227d0
merge: resolve conflicts with main
figtracer Mar 31, 2026
1b0e9ec
ci: set EF_TEST_TRIE env var for execution witness tests
figtracer Mar 31, 2026
f0edf76
move func to assert.rs
jsign Mar 31, 2026
eb4423f
refactor: update assert functions import and visibility in models
jsign Apr 5, 2026
d227eb7
Merge branch 'main' into jsign/witness-generation-testing
jsign Apr 5, 2026
c52abfb
rebase fix
jsign Apr 5, 2026
444944d
improvements
jsign Apr 6, 2026
402659c
Merge branch 'main' into jsign/witness-generation-testing-rebased
jsign Apr 6, 2026
6406a96
update reth
jsign Apr 6, 2026
969b7fe
allow test skip list
jsign Apr 6, 2026
95174b5
add skip lits
jsign Apr 6, 2026
315fcda
fmt
jsign Apr 6, 2026
4a69b22
lint
jsign Apr 6, 2026
6846e66
lint
jsign Apr 6, 2026
e2a4498
update reth dep
jsign Apr 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,24 @@ jobs:
- name: Run EF tests
run: ./scripts/run_ef_tests.sh ${{ matrix.trie }}

execution-witness-tests:
Comment thread
jsign marked this conversation as resolved.
Comment thread
jsign marked this conversation as resolved.
name: Execution Witness tests
runs-on: ubuntu-latest
timeout-minutes: 30
env:
RUST_LOG: info
RUST_BACKTRACE: 1
EF_TEST_TRIE: default
EXECUTION_WITNESS_TESTS_URL: https://github.com/jsign/artifacts/releases/download/execution_witness_v0.0.1/execution_witness_tests_409fae8.tar.gz
steps:
- uses: actions/checkout@v4
- uses: dtolnay/rust-toolchain@stable
- uses: Swatinem/rust-cache@v2
with:
cache-on-failure: true
- name: Run Execution Witness tests
run: cargo run -p ef-test-runner --release -- --skip testing/runner/execution-witness-skip.txt $EXECUTION_WITNESS_TESTS_URL
Comment on lines +58 to +73
Copy link
Copy Markdown
Contributor Author

@jsign jsign Apr 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I mentioned in a comment, there are now official spec and tests.

But since they are meant to run on top of hte latest BAL devnet EL branches, for this PR I decided to keep these older execution witness tests, just temporarily.

Not all the tests pass though, and the reason why is explained in the execution-witness-skip.txt file. I believe teh reason for it will also be a problem whenever the official tests are run.

I would say to:

  • Merge this PR with this CI as is, since it can provide guarantees on a lot of passing tests until official releases are used.
  • I can create a issue on this repo to explain in more detail that using official spec tests should be done, and provide more details that can help do that work.

Copy link
Copy Markdown
Collaborator

@figtracer figtracer Apr 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we're running these official fixtures at stateless@bal-devnet-3
main...bal-devnet-3#diff-e723b0fac5c1b72ac28debd4e719da6375ed298123f05186e64f5088677235fbR33

still some things to do regarding the ability to debug the tests properly (some don't pass) but most of the reth@bal-devnet-3 patching has been done

Merge this PR with this CI as is, since it can provide guarantees on a lot of passing tests until official releases are used.

we should wait for upstream first imo, the detached commit problem would also be solved

I can create a issue on this repo to explain in more detail that using official spec tests should be done, and provide more details that can help do that work.

would be very appreciated :)

Copy link
Copy Markdown
Contributor Author

@jsign jsign Apr 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, sounds great you're doing progress in that branch 🔥

I'll create the issue to explain things in more detail later/soon today.


no-std:
name: no_std (RISC-V)
runs-on: ubuntu-latest
Expand Down
Loading
Loading