Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add bindings for riscv64gc-unknown-linux-gnu target #251

Merged
merged 1 commit into from
Mar 27, 2025

Conversation

hug-dev
Copy link
Member

@hug-dev hug-dev commented Mar 27, 2025

Pushing #212 to the finish line!

This change adds riscv64gc-unknown-linux-gnu bindings for cryptoki-sys crate and adds the target to ci.sh and regenerate_bindings.sh for future updates. This change will enable building the package for risvc in Fedora.

@hug-dev hug-dev force-pushed the riscv64gc-unknown-linux-gnu branch 2 times, most recently from 127f2cd to 6117e06 Compare March 27, 2025 10:30
This change adds riscv64gc-unknown-linux-gnu bindings for cryptoki-sys
crate and adds the target to ci.sh and regenerate_bindings.sh for future
updates. This change will enable building the package for risvc in
Fedora.

Signed-off-by: Neil Hanlon <[email protected]>
@hug-dev hug-dev force-pushed the riscv64gc-unknown-linux-gnu branch from 6117e06 to 911c3b8 Compare March 27, 2025 10:35
@hug-dev hug-dev marked this pull request as ready for review March 27, 2025 10:38
Copy link
Collaborator

@wiktor-k wiktor-k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks clean. I can't test this though but 🤞

Copy link
Member

@ionut-arm ionut-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hug-dev hug-dev merged commit 359f2ff into parallaxsecond:main Mar 27, 2025
7 checks passed
@hug-dev hug-dev deleted the riscv64gc-unknown-linux-gnu branch March 27, 2025 10:51
@NeilHanlon
Copy link
Contributor

Thank you for pushing this across the line! We'll test this in Fedora :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants