SMALLFIX: Account non_seq setup/hold checks in cycle accounting#462
Open
akashlevy wants to merge 1 commit into
Open
SMALLFIX: Account non_seq setup/hold checks in cycle accounting#462akashlevy wants to merge 1 commit into
akashlevy wants to merge 1 commit into
Conversation
non_seq_setup/hold timing types were omitted from setSetupAccting and setHoldAccting, so release and capture incorrectly shared the same edge. Co-authored-by: Cursor <cursoragent@cursor.com>
akashlevy
marked this pull request as ready for review
July 11, 2026 20:40
akashlevy
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TimingRole::nonSeqSetup()inCycleAccting::setSetupAccting.TimingRole::nonSeqHold()inCycleAccting::setHoldAccting.non_seq_timingregression covering CKMUX-style non_seq checks.Motivation
non_seq_setup_*/non_seq_hold_*liberty timing types were not registered in cycle accounting, so release and capture incorrectly used the same clock edge when reporting those checks.Test plan
./regression non_seq_timing(local)Made with Cursor