SMALLFIX: Fix port-to-pin conversion for names containing slashes#463
Open
akashlevy wants to merge 1 commit into
Open
SMALLFIX: Fix port-to-pin conversion for names containing slashes#463akashlevy wants to merge 1 commit into
akashlevy wants to merge 1 commit into
Conversation
Use get_port_pin instead of find_pin on the port leaf name so escaped hierarchical port names like level1/level2/level3 resolve correctly. Also fix arglilst typo in get_port_pins_error. Co-authored-by: Cursor <cursoragent@cursor.com>
akashlevy
marked this pull request as ready for review
July 11, 2026 20:38
akashlevy
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
find_pin [get_name $port]withget_port_pin $portinCmdArgs.tclandNetworkEdit.tclwhen converting Port objects to pins.arglilsttypo inget_port_pins_errorso backslash escaping of the argument list is applied.slash_port_testregression with escaped hierarchical port names (level1/level2/level3,a/b, etc.).Motivation
Escaped Verilog port names that contain
/are valid but were broken when Port→Pin conversion used the leaf name withfind_pin, which treats/as hierarchy.Test plan
./regression slash_port_test(local)Made with Cursor