Implement SED models and GalaxySED model generator#84
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request implements a comprehensive SED modeling framework for galaxies, introducing new modules for model parameter management (model.py), SED components (sed.py), and galaxy-scale modeling (galaxy.py). It significantly expands the dust module with attenuation curves, emission models, and calorimetric coupling. The PR also refactors the chemical evolution models from models.py to cem.py with backward compatibility via deprecation warnings.
Changes:
- Introduces Parameter/ModelBase infrastructure for consistent parameter management across all models
- Adds GalaxySED class for composite galaxy SED modeling with stellar, dust attenuation, and dust emission components
- Expands dust module with AttenuationCurve, AttenuationModel, Casey2012DustComponent, and CalorimetricDustComponent
- Refactors models.py → cem.py with new models (BetaCEM) and enhanced features (age binning for SED/photometry)
- Adds FilterList class for vectorized photometry computations
- Comprehensive test coverage for all new components
Reviewed changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated 40 comments.
Show a summary per file
| File | Description |
|---|---|
| src/pst/model.py | New Parameter and ModelBase classes for unified parameter management |
| src/pst/sed.py | SedComponent base class and StellarComponent implementation |
| src/pst/galaxy.py | GalaxySED composite model with redshift handling and parameter indexing |
| src/pst/dust.py | Major expansion: attenuation curves/models, dust emission, calorimetric coupling |
| src/pst/cem.py | Refactored chemical evolution models with new features and BetaCEM |
| src/pst/models.py | Deprecation wrapper maintaining backward compatibility |
| src/pst/observables.py | FilterList class for vectorized photometry, improved Filter methods |
| src/pst/utils.py | New check_parameter and broadcast_to_axis utilities |
| tests/* | Comprehensive test coverage for new modules |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.