Track batch progress per comment, not per batch#12
Open
Sfgangloff wants to merge 1 commit into
Open
Conversation
A submitted batch can hold several comments. The page treated a batch as "done" as soon as the agent answered any one of its comments: the processing state cleared and the remaining comments disappeared from the panel, so they looked handled when they weren't. Now the page checks each comment id against history. The batch only clears once every comment has been answered. While some are still open it shows "N/M done" and marks each comment "awaiting" or "addressed", so nothing in a batch gets silently dropped. SKILL.md now tells the agent to answer every comment in a batch. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10.
The bug
A batch can hold several comments. The page treated the whole batch as done as soon as the agent answered any one of them: the processing state cleared and the remaining comments disappeared from the panel, so they looked handled when they weren't.
The fix
The page now checks each comment id against history. The batch only clears once every comment has been answered. While some are still open it shows
N/M doneand marks each comment "awaiting" or "addressed", so nothing in a batch gets silently dropped.SKILL.mdnow tells the agent to answer every comment in a batch.Changed:
lib/feedback.js,lib/feedback.css,SKILL.md.Testing
Booted the real
feedback.jsin jsdom with a seeded 3-comment batch and fed it differenthistory.jsonstates:1/3 done, 2 awaiting + 1 addressed (before the fix the banner wrongly cleared — verified against the currentmain).All checks pass. Happy to share the harness.