Fix failure to upload vdso #17
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Originally PR parca-dev#4.
Support native custom labels
Merge remote-tracking branch 'origin/main'
Update Go runtime data
On x86, finding thread-local variables requires us to know the size of the per-thread TLS image. This is the .tdata section followed by the .tbss section. Previously, we were only taking into account the .tbss section, which was not caught earlier because I only tested with programs where .tdata was empty on x86.
Look at .tdata when computing TLS image size
Rather than require a match on the exact version, we should just match on major+minor, and fall back to the latest version if we don't find a result.
…-dev#13) Otherwise we will use whatever happens to be in the map from the previous run, which might be nonzero.
Disable 4.19 which doesn't work with custom labels hashing
Fix coredump compilation
umanwizard
force-pushed
the
main
branch
2 times, most recently
from
5b64dd5 to
d1cfbd5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VDSO was never uploaded because of failure of opening. To be compatible with ReadAtCloser interface, I add a fake closer wrapper for the in-memory VDSO.