Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support JPEG XL Image Converter #10015

Open
wants to merge 4 commits into
base: v2
Choose a base branch
from
Open

Support JPEG XL Image Converter #10015

wants to merge 4 commits into from

Conversation

solonovamax
Copy link

@solonovamax solonovamax commented Nov 18, 2024 •
edited
Loading

↪️ Pull Request

Adds support for converting images to JPEG XL.

Closes #10003

💻 Examples

<!DOCTYPE html>
<html>
  <head>
    <meta charset="utf-8" />
    <title>HTML Example</title>
  </head>
  <body>
    <picture>
      <source srcset="image.jpeg?as=avif&width=800" type="image/avif" />
      <source srcset="image.jpeg?as=jxl&width=800" type="image/jxl" /> <!--- JPEG XL image -->
      <source srcset="image.jpeg?as=webp&width=800" type="image/webp" />
      <source srcset="image.jpeg?width=800" type="image/jpeg" />
      <img src="image.jpeg?width=200" alt="test image" />
    </picture>
  </body>
</html>

✔️ PR Todo

  • Added/updated unit tests for this change
  • Filled out test instructions (In case there aren't any unit tests)
  • Included links to related issues/PRs

solonovamax added a commit to solonovamax/website that referenced this pull request Nov 18, 2024
@solonovamax
Update documentation to reflect parcel-bundler/parcel#10015
8bfc37a 
Also clarify some stuff about AVIF.
This was referenced Nov 18, 2024
Open
Open
@solonovamax solonovamax force-pushed the feature/jpegxl-image-converter branch from 4d8c44c to c10287f Compare November 18, 2024 18:28
@devongovett devongovett enabled auto-merge (squash) December 26, 2024 00:08
@solonovamax
Copy link
Author

solonovamax commented Mar 20, 2025 •
edited
Loading

The issue with the failing test has to do with sharp being unable to detect a new enough libvips version.

Since sharp seems to update libvips versions really fast (currently, the latest sharp version requires libvips >= 8.16.1, which was released only one week ago. sharp also seems to have updated to libvips 8.16.1 at nearly the exact same time as the release was published, per github commits), should we disable the tests for jpegxl, as it's unreasonable to constantly try to track that for CI?

also, looking at this again, I realized that I never added a way to configure the jpeg xl sharp parameters. I'm going to do that in a quick commit.

I'm also going to quickly rebase onto the latest commit to the v2 branch.

auto-merge was automatically disabled March 20, 2025 04:49

Head branch was pushed to by a user without write access

@solonovamax solonovamax force-pushed the feature/jpegxl-image-converter branch from e4d0e54 to 47ad7cd Compare March 20, 2025 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devongovett devongovett devongovett approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support JPEG XL
2 participants
@solonovamax @devongovett