Install .NET 10 SDK in Windows setup action #745
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - name: Setup .NET SDK ${{inputs.architecture}} | ||
| uses: actions/setup-dotnet@v4 | ||
| with: | ||
| dotnet-version: '10.0.x' | ||
| architecture: ${{inputs.architecture}} |
There was a problem hiding this comment.
The new actions/setup-dotnet@v4 step installs the 10.0 SDK into the hosted tool cache and sets DOTNET_ROOT/disables multi-level lookup for the job. The later PowerShell block still drops all required runtimes into ${{steps.get-program-files.outputs.path}}/dotnet (Program Files). Because the active dotnet on PATH now points to the tool cache, it no longer sees those runtimes, so Windows .NET tests targeting netcoreapp3.x–net9.0 will fail with “No compatible framework version was found”. Install the extra runtimes into DOTNET_ROOT (or re-enable multi-level lookup) so the SDK can locate them.
Useful? React with 👍 / 👎.
Test Results 128 files 128 suites 7m 59s ⏱️ Results for commit 3559f50. ♻️ This comment has been updated with latest results. |
Summary
Testing
Codex Task