chore(cli): add support for mobile signing#189
Merged
Merged
Conversation
CI Summary
Release - PassedTest this PR Download artifact (GitHub CLI required): gh run download 27687059625 -n cli-release-0.0.0-pr.189 -R paritytech/dotns-sdkInstall globally: npm install -g ./parity-dotns-cli-0.0.0-pr.189.tgzVerify: dotns --helpDeploy UI — FailedFailed at: Deploy — Deploy workflow failed — see run logs for upload/register/contenthash details
Deploy Example — Passed
Benchmark UI - Failed (0s)
Labelspkg: cli, type: docs, type: test, dependencies, pkg: ui Test - Failed265 passed, 2 failed across 267 tests. Failed tests:
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
## Description ## Type - [x] Bug fix - [ ] Feature - [ ] Breaking change - [ ] Documentation - [ ] Chore ## Package - [ ] `@parity/dotns-cli` - [x] dotns-ui - [ ] Root/monorepo - [ ] Documentation ## Related Issues ## Fixes ## Checklist ### Code - [ ] Follows project style - [ ] `bun run lint` passes - [ ] `bun run format` passes - [ ] `bun run typecheck` passes ### Documentation - [ ] README updated if needed - [ ] Types updated if needed ### Breaking Changes - [ ] No breaking changes - [ ] Breaking changes documented below **Breaking changes:** ## Testing How to test: 1. 2. ## Notes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds experimental mobile signing for the cli
Type
Package
@parity/dotns-cliRelated Issues
Fixes
Checklist
Code
bun run lintpassesbun run formatpassesbun run typecheckpassesDocumentation
Breaking Changes
Breaking changes:
Testing
How to test:
Notes