add transient storage support in polkadot test execution mode
#449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexggh
reviewed
Dec 10, 2025
| array-bytes = { version = "6.2.2", default-features = false } | ||
| codec = { version = "3.7.5", default-features = false, package = "parity-scale-codec" } | ||
| polkadot-sdk = { git = "https://github.com/paritytech/polkadot-sdk.git", branch = "master", default-features = false, features = [ | ||
| polkadot-sdk = { git = "https://github.com/paritytech/polkadot-sdk.git", branch = "pkhry/external_transient_storage", default-features = false, features = [ |
Author
There was a problem hiding this comment.
will use latest master as soon as the pr is merged
alexggh
approved these changes
Dec 10, 2025
filip-parity
approved these changes
Dec 10, 2025
pkhry
force-pushed
the
pkhry/transients
branch
from
2a811e5 to
b98ae85
Compare
smiasojed
reviewed
Jan 29, 2026
| pub const CodeHashLockupDepositPercent: Perbill = Perbill::from_percent(0); | ||
| pub const NativeToEthRatio: u32 = 1_000_000; | ||
| pub const GasScale : u32 = 1_000_000; | ||
| pub const GasScale : u32 = 100_000_000; |
smiasojed
reviewed
Jan 29, 2026
| let ctx = get_context_ref(ctx); | ||
| let mut state = ctx.externalties.0.lock().unwrap(); | ||
| let _ = state.externalities.ext().storage_rollback_transaction(); | ||
| state.transient_storage.rollback_transaction(); |
Collaborator
There was a problem hiding this comment.
maybe we could wrap this functionality and just call rollback_transaction()
instead of calling rollback on transient storage and storage?
Similarly we could do it for start_transaction. WDYT?
smiasojed
approved these changes
Jan 29, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
depends on #424