Add warning when overflow happens #503
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkhry
approved these changes
Jan 22, 2026
|
|
||
| let u128_max: U256 = U256::from(u128::MAX); | ||
| let clamped_amount = if amount > u128_max { | ||
| tracing::info!( |
There was a problem hiding this comment.
Here it's info and in state it's warn. Shouldn't this be consistent?
Collaborator
Author
There was a problem hiding this comment.
The issue was that it flooded the terminal. The migration runs during each test for 15 accounts which are funded with u256::max, so I decided to decrease the log level.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an overflow happens on the block timestamp, block number, or balance while using cheatcodes, a warning is triggered and the value is rounded to the maximum possible value. For
CALLandCREATEopcodes with an excessively high balance, a revert is triggered.