Anvil: Introduce forking-support flag to enable forking support #505
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
re-gius
reviewed
Jan 30, 2026
re-gius
left a comment
re-gius
left a comment
There was a problem hiding this comment.
Avoid code duplication for new_client method. Apart from that, looks good to me
| Ok((Arc::new(client), backend, keystore_container.keystore(), task_manager)) | ||
| } | ||
|
|
||
| #[cfg(not(feature = "forking-support"))] |
There was a problem hiding this comment.
You should avoid duplicating critical code in this case, so it's better to leave it as a single function new_client and use #[cfg(not(feature = "forking-support"))]/#[cfg(feature = "forking-support")] inside its body for the different execution flows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a
forking-supportfeature flag that allows conditional compilation of the chain forking functionality. When enabled (which is the default), the crate uses the lazy loading backend that supports forking from remote chains by fetching state on-demand. When disabled, it falls back to the standardsc_service::new_db_backend, resulting in a lighter build that doesn't include the lazy loading infrastructure.This separation is particularly useful during debugging sessions where the lazy loading backend is not needed, allowing developers to isolate and troubleshoot issues without the additional complexity of the remote state fetching layer