Use patched ws-rs #583
Use patched ws-rs #583
Conversation
ws/Cargo.toml
Outdated
| @@ -7,7 +7,7 @@ homepage = "https://github.com/paritytech/jsonrpc" | |||
| license = "MIT" | |||
| name = "jsonrpc-ws-server" | |||
| repository = "https://github.com/paritytech/jsonrpc" | |||
| version = "14.2.0" | |||
| version = "14.2.1" | |||
There was a problem hiding this comment.
Or should it be 14.3.0? cc @ordian
There was a problem hiding this comment.
I think that's technically a breaking change (so should be 15.0.0) because of pub use parity_ws as ws; (it's also exposed in other public API): ws 0.9 and parity-ws 0.10 are two different (semver-incompatible) crates.
There was a problem hiding this comment.
Yeah, seems the ws stuff is exposed for instance in middlewares, which for sure are used by openethereum (not necessarily substrate though).
Let's bump to 15.0.0 then.
There was a problem hiding this comment.
@tomusdrw should I bump the version in the PR, and if so, should all crates be bumped to 15.0.0 or just the jsonrpc-ws-server?
There was a problem hiding this comment.
should I bump the version in the PR, and if so, should all crates be bumped to 15.0.0 or just the jsonrpc-ws-server?
Yes and yes. We prefer to keep the major versions synchronized for simplicity even though there weren't any breaking changes.
There was a problem hiding this comment.
would it make sense to create a v15.x branch for that instead of merging it to v14.x?
There was a problem hiding this comment.
I think not; I think the current v15 branch has unrelated and breaking changes. If this here becomes v15, then the current v15-branch will become v16 (correct me if I'm wrong @tomusdrw).
There was a problem hiding this comment.
@dvdplm could you point me to the v15 branch? I don't see it listed here https://github.com/paritytech/jsonrpc/branches/all.
Or did you mean master? I think master can later become v16 if that's what you mean.
| @@ -64,6 +64,8 @@ impl Server { | |||
| config.max_connections = max_connections; | |||
| // don't accept super large requests | |||
| config.max_fragment_size = max_payload_bytes; | |||
| config.max_in_buffer_capacity = max_payload_bytes; | |||
There was a problem hiding this comment.
Initially I thought that maybe it's too little, but the default 5MB for this should be more than enough for a bunch of requests.
|
Bumped versions to 15.0.0 across the board, but merging this to the 14.x branch now doesn't make literal sense. |
Revert to
ws-rsonce housleyjk/ws-rs#328 is merged and published.