Skip to content

Avoid panics returning error instead #509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lexnv merged 2 commits into from
Jan 12, 2026
Merged

Avoid panics returning error instead #509

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1d08c49
Avoid panics returning error instead
dimartiro Jan 12, 2026
83d0318
Merge branch 'master' into avoid-panics
dimartiro Jan 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 21 additions & 4 deletions src/transport/webrtc/opening.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -409,8 +409,15 @@ impl OpeningWebRtcConnection {
continue;
}

// TODO: https://github.com/paritytech/litep2p/issues/350 no expect
self.on_noise_channel_open().expect("to succeed");
if let Err(error) = self.on_noise_channel_open() {
tracing::debug!(
target: LOG_TARGET,
connection_id = ?self.connection_id,
?error,
"noise channel open failed",
);
return WebRtcEvent::ConnectionClosed;
}
}
Event::ChannelData(data) => {
tracing::trace!(
Expand All @@ -428,8 +435,18 @@ impl OpeningWebRtcConnection {
continue;
}

// TODO: https://github.com/paritytech/litep2p/issues/350 no expect
return self.on_noise_channel_data(data.data).expect("to succeed");
match self.on_noise_channel_data(data.data) {
Ok(event) => return event,
Err(error) => {
tracing::debug!(
target: LOG_TARGET,
connection_id = ?self.connection_id,
?error,
"noise channel data handling failed",
);
return WebRtcEvent::ConnectionClosed;
}
}
}
Event::ChannelClose(channel_id) => {
tracing::debug!(target: LOG_TARGET, ?channel_id, "channel closed");
Expand Down
Loading