wip/transport: Make accept async to close the gap on service races #525
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
Signed-off-by: Alexandru Vasile <[email protected]>
bkchr
reviewed
Jan 30, 2026
Comment on lines
+670
to
+685
| // /// Start running event loop of [`WebRtcConnection`]. | ||
| // pub async fn run(mut self) { | ||
| // tracing::trace!( | ||
| // target: LOG_TARGET, | ||
| // peer = ?self.peer, | ||
| // "start webrtc connection event loop", | ||
| // ); | ||
|
|
||
| // let _ = self | ||
| // .protocol_set | ||
| // .report_connection_established(self.peer, self.endpoint.clone()) | ||
| // .await; | ||
|
|
||
| // self.run_event_loop().await; | ||
| // } | ||
|
|
Member
There was a problem hiding this comment.
Suggested change
| // /// Start running event loop of [`WebRtcConnection`]. | |
| // pub async fn run(mut self) { | |
| // tracing::trace!( | |
| // target: LOG_TARGET, | |
| // peer = ?self.peer, | |
| // "start webrtc connection event loop", | |
| // ); | |
| // let _ = self | |
| // .protocol_set | |
| // .report_connection_established(self.peer, self.endpoint.clone()) | |
| // .await; | |
| // self.run_event_loop().await; | |
| // } |
| pub async fn next(&mut self) -> Option<TransportEvent> { | ||
| loop { | ||
| // First, check if we have a pending accept future to poll | ||
| if let Some((peer, endpoint, mut future)) = self.pending_accept.take() { |
Member
There was a problem hiding this comment.
So we "stop" here everything when one connection is waiting for its accept to finish?
Collaborator
Author
There was a problem hiding this comment.
Yep, this is not ok, especially under load. The PR is entirely vibed as PoC for @tdimitrov 🙏
I'll need to rewrite this with some FuturesUnordered and see ask Tsvetomir for another testing round 🙏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.