Skip to content

Conversation

cchudant
Copy link

The rocksdb crate supports a feature called multi-threaded-cf, which wraps column family descriptors into RwLocks. and change some types around.
Enabling it in a downstream app makes kvdb-rocksdb then fail to compile.

Questions:

  • should I add a compile test to the CI to make sure future changes compile under that rocksdb flag?

@ordian
Copy link
Contributor

ordian commented Aug 10, 2024

should I add a compile test to the CI to make sure future changes compile under that rocksdb flag?

yes, please

do you think we should also expose this feature in kvdb-rocksdb? as in

[features]
# ...
multi-threaded-cf = ["rocksdb/multi-threaded-cf"]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants