Skip to content

Commit d3fb4c7

Browse files
fix(telemetry): stop overriding deploy.source with "playground-cli" (#129)
deploy.source is bulletin-deploy's own attribute with a fixed semantic: "ci" or "local". Passing "playground-cli" as a custom attribute value overwrites that value on the active deploy span, so bulletin-deploy's dashboards see "playground-cli" instead of the expected "ci"/"local". deploy.host_app="playground-cli" is already set via the BULLETIN_DEPLOY_HOST_APP env var wired in bootstrap.ts, so the host identity is fully captured without touching deploy.source.
1 parent 7bf4166 commit d3fb4c7

1 file changed

Lines changed: 2 additions & 8 deletions

File tree

src/utils/deploy/storage.ts

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -43,10 +43,7 @@ export interface StorageDeployOptions {
4343
onLogEvent?: (event: DeployLogEvent) => void;
4444
/** Target environment — currently only `testnet` is supported. */
4545
env?: Env;
46-
/**
47-
* Extra telemetry attributes merged into bulletin-deploy's deploy span.
48-
* Defaults to `{ "deploy.source": "playground-cli" }`.
49-
*/
46+
/** Extra telemetry attributes merged into bulletin-deploy's deploy span. */
5047
attributes?: Record<string, string>;
5148
}
5249

@@ -76,10 +73,7 @@ export async function runStorageDeploy(options: StorageDeployOptions): Promise<D
7673
// WebContainer-safe path for metadata upload.
7774
rpc: cfg.bulletinRpc,
7875
...options.auth,
79-
attributes: {
80-
"deploy.source": "playground-cli",
81-
...options.attributes,
82-
},
76+
attributes: options.attributes,
8377
});
8478
} finally {
8579
restore();

0 commit comments

Comments
 (0)