Skip to content

Conversation

@raymondkfcheung
Copy link
Contributor

@raymondkfcheung raymondkfcheung commented Nov 27, 2025

Extends Stored and Renewed events with a hash: ContentHash field.

Addresses #86, #123

@raymondkfcheung raymondkfcheung self-assigned this Nov 27, 2025
@raymondkfcheung raymondkfcheung added the enhancement New feature or request label Nov 27, 2025
@raymondkfcheung raymondkfcheung enabled auto-merge (squash) November 27, 2025 13:41
Copy link
Contributor

@x3c41a x3c41a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from Rust point of view

@raymondkfcheung raymondkfcheung merged commit f33c8a9 into paritytech:main Nov 27, 2025
7 checks passed
pub enum Event<T: Config> {
/// Stored data under specified index.
Stored { index: u32 },
Stored { index: u32, hash: ContentHash },
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please, hash -> content_hash

@raymondkfcheung raymondkfcheung deleted the ray-add-events branch November 28, 2025 09:40
github-merge-queue bot pushed a commit to paritytech/polkadot-sdk that referenced this pull request Dec 3, 2025
* Align events between Bulletin and SDK
* Extends `Stored` and `Renewed` events with a `hash: ContentHash`
field.
* Replaces `log` with `tracing` to match Bulletin’s logging approach.

Addresses
paritytech/polkadot-bulletin-chain#86,
paritytech/polkadot-bulletin-chain#123

Relates to
- [x] paritytech/polkadot-bulletin-chain#124
- [x] paritytech/polkadot-bulletin-chain#127
- [x] paritytech/polkadot-bulletin-chain#129

---------

Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
paritytech-release-backport-bot bot pushed a commit to paritytech/polkadot-sdk that referenced this pull request Dec 3, 2025
* Align events between Bulletin and SDK
* Extends `Stored` and `Renewed` events with a `hash: ContentHash`
field.
* Replaces `log` with `tracing` to match Bulletin’s logging approach.

Addresses
paritytech/polkadot-bulletin-chain#86,
paritytech/polkadot-bulletin-chain#123

Relates to
- [x] paritytech/polkadot-bulletin-chain#124
- [x] paritytech/polkadot-bulletin-chain#127
- [x] paritytech/polkadot-bulletin-chain#129

---------

Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
(cherry picked from commit f757162)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants