Bring main branch up to date #14

dmitry-markin · 2025-07-03T06:46:57Z

This merges commit ebebf30 into main branch. This is the commit most of the current work is based on, and merging it should bring us closer to working on the main branch.

The diverging changes on main (as compared to ebebf30) should not bring any conflicts:

2024-10-29 52d9260 disable dependabot
2024-10-30 a0e1bbc edit issue template
2024-11-15 fd079b8 ci: Upgrade actions/upload-artifact and actions/download-artifact to v4

There are no other changes on main compared to ebebf30.

This PR also:

Deprecates toolchain override in order to build on stable Rust.
Updates GitHub workflow to run cargo check on Parity CI container image with Rust version used in polkadot-sdk.

git-subtree-dir: bridges git-subtree-split: f346243f6d9da686e47f3c6e9e2d9a286b831dd4

As long as the account has keys to purge. This effectively allows members of the validator set to step back, as validators will only be included in the real validator set if they have provided session keys.

And decrement when their authorization is removed, so the account in frame_system gets cleaned up.

bf5b4cc1 Add polkadot bulletin chain primitives (#2542) git-subtree-dir: bridges git-subtree-split: bf5b4cc18c0ceaed308827627dd4effa5fd68c4a

…ge-pallets

…/842bef21e14a1cb66aec057be724042f90ee70be

aa1cf85d fix compilation 262e79fa RefundBridgedGrandpaMessages to refund transaction costs for messages coming to/from bridged standalone/relay chain (#2566) 50c33312 added POLKADOT_BULLETIN_CHAIN_ID constant e4a52cba prepare refund extension infra to add refund extension for messages from standalone chain (#2558) a7706c4a Add relays that will be used in Polkadot Bulletin <> Polkadot.BH bridge (#2556) 52d95e5a Polkadot Bulletin Chain client (#2552) 979acf3c instead of requiring sp_std::vec::Vec import when using runtime API generation macro, let's use full type path directly in macro (#2551) git-subtree-dir: bridges git-subtree-split: aa1cf85dd90c029b5c5cb8352be43680847595cc

* Squashed 'bridges/' content from commit f346243f git-subtree-dir: bridges git-subtree-split: f346243f6d9da686e47f3c6e9e2d9a286b831dd4 * add a BRIDGES.md document * brides -> bridges * trigger CI * Revert "trigger CI" This reverts commit a4390dc. * try sudo apt-get update

* add basic XCM configuration * and lost changes from Cargo.toml * allow all calls through the bridge * remove TODO and keep using root to dicspatch incoming calls * improve matching * Update runtime/src/xcm_config.rs Co-authored-by: Branislav Kontur <[email protected]> * Update runtime/src/xcm_config.rs Co-authored-by: Branislav Kontur <[email protected]> * Update runtime/src/xcm_config.rs Co-authored-by: Branislav Kontur <[email protected]> * UniversalAliases + WithComputedOrigin * added TODO * Update runtime/src/xcm_config.rs Co-authored-by: Branislav Kontur <[email protected]> * changed expected_message_from_kawabunga_passes_barrier to match real execution params --------- Co-authored-by: Branislav Kontur <[email protected]>

* updating bridges subtree + remove extra folders * update BRIDGES.md * added basic (unworking) bridge configuration * and lost related changes from node * also lost changes from Cargo.toml * removed NeverSentMessage for now

* add RPC required for bridges relay * apply review suggestions

dmitry-markin · 2025-07-03T10:31:05Z

The CI step Cargo check (benchmarking) that checks the node with --features=runtime-benchmarks is failing, but I think we can leave it as a follow-up.

georgepisaltu

Looks good but can you also port this change from the george-update branch please?

Signed-off-by: georgepisaltu <[email protected]>

antkve

LGTM. My commits revert the switch from rococo to polkadot, but this should be easy to merge into subsequent changes to this branch.

antkve · 2025-07-03T16:24:57Z

The CI step Cargo check (benchmarking) that checks the node with --features=runtime-benchmarks is failing, but I think we can leave it as a follow-up.

error:#[no_mangle] cannot be used on internal language items
Sounds like we need to use rustc 1.79.0 or .84.1 instead of 1.75.0 to compile here?

dmitry-markin · 2025-07-03T18:24:58Z

error:#[no_mangle] cannot be used on internal language items Sounds like we need to use rustc 1.79.0 or .84.1 instead of 1.75.0 to compile here?

Tried with rust 1.88.0 (latest stable) & 1.90.0 (latest nightly), but the error is the same.

dmitry-markin · 2025-07-03T18:34:09Z

Sounds like we need to use rustc 1.79.0 or .84.1 instead of 1.75.0 to compile here?

Nice catch, thanks! Updated CI image to 1.84.1 to match the one used in polkadot-sdk.

antkve · 2025-07-03T19:56:04Z

Think this ^ is needed to stop it upgrading to stable during install

antkve · 2025-07-03T22:10:23Z

Hmm, rust version is correct now but benchmarking still not building. Think we should leave this to its own issue since it looks like it's just a whole bunch of errors caused by the benchmarking code not being updated with the polkadot-sdk version change.

dmitry-markin · 2025-07-04T08:40:40Z

The issue for fixing benchmarking: #15

dmitry-markin · 2025-07-04T08:51:01Z

Think this ^ is needed to stop it upgrading to stable during install

Honestly I don't know what is better — upgrade Rust as one of CI steps, or use Rust from the container. Let's keep the latter, but keep in mind we will need to manually update the version to follow polkadot-sdk CI to not run into weird errors.

- Add authorize_account_for_size() convenience method that estimates and authorizes in one call - Add signer_account() method to TransactionSubmitter trait to derive account from signer - Update AsyncBulletinClient to automatically use signer's account if not explicitly set - Clarify authorization documentation: mention Root/sudo requirement and no fees - Clarify estimate_authorization helper purpose in docs Addresses franciscoaguirre's comments: - Comment #15: API that calls estimation underneath - Comments #16/#17: Get account from keypair/signer automatically - Comment #11: Clarify 'required values' in authorization docs - Comment #14: Mention Root requirement and no fees for authorization

svyatonik and others added 30 commits September 7, 2023 12:49

Squashed 'bridges/' content from commit f346243f

b1e3957

git-subtree-dir: bridges git-subtree-split: f346243f6d9da686e47f3c6e9e2d9a286b831dd4

updating bridges subtree + remove extra folders

2b87ead

add a BRIDGES.md document

b5aaee1

Allow purge_keys to be called

1149763

As long as the account has keys to purge. This effectively allows members of the validator set to step back, as validators will only be included in the real validator set if they have provided session keys.

Inc provider ref count of authorized accounts

66dd4cc

And decrement when their authorization is removed, so the account in frame_system gets cleaned up.

brides -> bridges

ec1465e

Remove ISSUE_TEMPLATE

ff535df

add bridge pallets to runtime

858f6cd

Squashed 'bridges/' changes from f346243f..bf5b4cc1

bf23cd6

bf5b4cc1 Add polkadot bulletin chain primitives (#2542) git-subtree-dir: bridges git-subtree-split: bf5b4cc18c0ceaed308827627dd4effa5fd68c4a

Merge commit 'bf23cd6e408e2c3beed1550fcb8b46527e38502c' into add-brid…

189d66f

…ge-pallets

use bp_polkadot_bulletin in bridge declaration

e2358e8

https://github.com/paritytech/parity-bridges-common/pull/2551/commits…

bd40aaa

…/842bef21e14a1cb66aec057be724042f90ee70be

whitelsited relayers set

adbc4b9

update bridges subtree

b12e3e9

added xcm config

265807a

dispatcher prototype

61d4a9f

flush

61fd23f

some changes to fix messages delivery + dispatch

d6b38b5

benchmarks

4d8afed

more tests for bridge

a1536c1

also bridge integrity tests

fa4d17a

last pack of tests

8c86438

Add bridge pallets + basic bridge configuration (#28)

010cffd

* updating bridges subtree + remove extra folders * update BRIDGES.md * added basic (unworking) bridge configuration * and lost related changes from node * also lost changes from Cargo.toml * removed NeverSentMessage for now

Merge remote-tracking branch 'zdave-parity/main' into add-bridge-pallets

bfd6bcd

Add RPC API required for bridges relay (#32)

3390898

* add RPC required for bridges relay * apply review suggestions

Merge remote-tracking branch 'zdave-parity/main' into add-bridge-pallets

cfbb7ef

add bridge dispatcher and exporter

f1c4d03

serban300 added 6 commits October 30, 2024 16:10

Remove bridges subtree

73d049d

Upgrade polkadot-bulletin-chain-runtime

377d53e

Upgrade node

b4aec97

Set polkadot-sdk rev

055feee

Bridge to Rococo

8fc7cbb

Other fixes

ebebf30

dmitry-markin requested review from antkve and georgepisaltu July 3, 2025 06:46

dmitry-markin added 5 commits July 3, 2025 09:51

Merge branch 'main' into common-base

bed8ccf

Move to rust stable

437b295

Use Parity CI image for workflow

b3c8038

minor: fix typo

378acaf

minor: workflow: use cd instead of pushd

cf3e28f

georgepisaltu approved these changes Jul 3, 2025

View reviewed changes

Add auth refresh

138f37f

Signed-off-by: georgepisaltu <[email protected]>

antkve approved these changes Jul 3, 2025

View reviewed changes

Bring CI container image up to date with polkadot-sdk

24d116e

Removed toolchain update

eeaeb94

dmitry-markin merged commit 194c3c2 into main Jul 4, 2025
3 of 4 checks passed

dmitry-markin deleted the common-base branch July 4, 2025 08:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bring main branch up to date #14

Bring main branch up to date #14

Uh oh!

dmitry-markin commented Jul 3, 2025 •

edited

Loading

Uh oh!

dmitry-markin commented Jul 3, 2025

Uh oh!

georgepisaltu left a comment

Uh oh!

antkve left a comment

Uh oh!

antkve commented Jul 3, 2025 •

edited

Loading

Uh oh!

dmitry-markin commented Jul 3, 2025

Uh oh!

dmitry-markin commented Jul 3, 2025 •

edited

Loading

Uh oh!

antkve commented Jul 3, 2025

Uh oh!

antkve commented Jul 3, 2025 •

edited

Loading

Uh oh!

dmitry-markin commented Jul 4, 2025

Uh oh!

dmitry-markin commented Jul 4, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

Bring main branch up to date #14

Bring main branch up to date #14

Uh oh!

Conversation

dmitry-markin commented Jul 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dmitry-markin commented Jul 3, 2025

Uh oh!

georgepisaltu left a comment

Choose a reason for hiding this comment

Uh oh!

antkve left a comment

Choose a reason for hiding this comment

Uh oh!

antkve commented Jul 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dmitry-markin commented Jul 3, 2025

Uh oh!

dmitry-markin commented Jul 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

antkve commented Jul 3, 2025

Uh oh!

antkve commented Jul 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dmitry-markin commented Jul 4, 2025

Uh oh!

dmitry-markin commented Jul 4, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

dmitry-markin commented Jul 3, 2025 •

edited

Loading

antkve commented Jul 3, 2025 •

edited

Loading

dmitry-markin commented Jul 3, 2025 •

edited

Loading

antkve commented Jul 3, 2025 •

edited

Loading