Skip to content

Conversation

@antkve
Copy link
Contributor

@antkve antkve commented Dec 15, 2025

Partially implements: #144

assert_ok!(res);
assert_ok!(res.unwrap());
}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@antkve when 8 (or 9) passes, then I would add here one more store with construct_and_apply_extrinsic, which should fail because of // 10 MiB (allows 9 MiB for normal transactions with 90% NORMAL_DISPATCH_RATIO), right?

We should also cover check_proof in block, so the ultimate test case would be like:

- successfully submit `check_proof` tx (later (as follow-up, when we merge [configurable StoragePeriod](https://github.com/paritytech/polkadot-sdk/pull/10662)), we should advance blocks so the full block is hit by `check_proof` ) (maybe we will need to tune `NORMAL_DISPATCH_RATIO` because of this)
- 8-9x submit **successfully** `construct_and_apply_extrinsic(store)`
- the last submit `construct_and_apply_extrinsic(store)` should fail

Copy link
Contributor Author

@antkve antkve Dec 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bkontur Okay but at the moment we'd need to advance it for the whole set storage period to call check_proof. Should I do that or just leave a TODO for when configurable StoragePeriod is merged?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bkontur Okay but at the moment we'd need to advance it for the whole set storage period to call check_proof. Should I do that or just leave a TODO for when configurable StoragePeriod is merged?

Create follow-up issue and TODO please

@bkontur bkontur marked this pull request as ready for review December 31, 2025 00:24
@bkontur bkontur enabled auto-merge (squash) December 31, 2025 00:24
@bkontur bkontur disabled auto-merge December 31, 2025 00:36
@bkontur bkontur merged commit 5fec423 into main Dec 31, 2025
8 checks passed
@bkontur bkontur deleted the ak-adjust-westend branch December 31, 2025 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants