Merge george-update into main
#16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: georgepisaltu <[email protected]>
Signed-off-by: georgepisaltu <[email protected]>
Signed-off-by: georgepisaltu <[email protected]>
Signed-off-by: georgepisaltu <[email protected]>
dmitry-markin
approved these changes
Jul 4, 2025
Contributor
dmitry-markin
left a comment
dmitry-markin
left a comment
There was a problem hiding this comment.
I don't really understand the bridging stuff — should it be reverted to use polkadot instead of rococo before the mainnet launch? I.e., we use this code for a testnet, but later move from rococo to polkadot?
Contributor
Yes that's pretty much it |
antkve
approved these changes
Jul 7, 2025
mudigal
added a commit
that referenced
this pull request
Jan 30, 2026
- Add authorize_account_for_size() convenience method that estimates and authorizes in one call - Add signer_account() method to TransactionSubmitter trait to derive account from signer - Update AsyncBulletinClient to automatically use signer's account if not explicitly set - Clarify authorization documentation: mention Root/sudo requirement and no fees - Clarify estimate_authorization helper purpose in docs Addresses franciscoaguirre's comments: - Comment #15: API that calls estimation underneath - Comments #16/#17: Get account from keypair/signer automatically - Comment #11: Clarify 'required values' in authorization docs - Comment #14: Mention Root requirement and no fees for authorization
x3c41a
pushed a commit
that referenced
this pull request
Feb 1, 2026
- Add authorize_account_for_size() convenience method that estimates and authorizes in one call - Add signer_account() method to TransactionSubmitter trait to derive account from signer - Update AsyncBulletinClient to automatically use signer's account if not explicitly set - Clarify authorization documentation: mention Root/sudo requirement and no fees - Clarify estimate_authorization helper purpose in docs Addresses franciscoaguirre's comments: - Comment #15: API that calls estimation underneath - Comments #16/#17: Get account from keypair/signer automatically - Comment #11: Clarify 'required values' in authorization docs - Comment #14: Mention Root requirement and no fees for authorization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.