Align store Function between Bulletin and SDK
#160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkontur
reviewed
Jan 2, 2026
| // checked by pre_dispatch_signed. | ||
| Self::ensure_data_size_ok(data.len())?; | ||
| if T::ChargeStorageFee::get() { | ||
| let sender = ensure_signed(origin)?; |
Collaborator
There was a problem hiding this comment.
let's wait with this a little bit, we need to fix feeless_if TODO and remove ValidateUnsigned and use AuthorizeCall extension first, because we also support unsigned transaction with ValidateUnsigned,
so if we allow ChargeStorageFee=true those will fail
Collaborator
There was a problem hiding this comment.
@RafalMirowski1 maybe just unrelated note, as we discussed "pass authorization from check_signed to the fn store over origin", I have a feeling that we could use it here also, or make this as a part of ValidateSigned, let's see
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #86
Depends on #162