Skip to content

Fix runtime build with the latest rustc #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dmitry-markin merged 4 commits into from
Jul 14, 2025
Merged

Fix runtime build with the latest rustc #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2953787
Fix runtime build with the latest `rustc`
dmitry-markin Jul 11, 2025
8e50734
Make sure to build runtime during CI cargo check stage
dmitry-markin Jul 11, 2025
18a1d9e
Add TODO item to remove the panic handler
dmitry-markin Jul 11, 2025
b80e93c
monor: typo
dmitry-markin Jul 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions .github/workflows/check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,8 +58,7 @@ jobs:
cache-all-crates: true

- name: Cargo check
run: |
SKIP_WASM_BUILD=1 cargo check
run: cargo check

check-benchmarking:
name: Cargo check (benchmarking)
Expand Down
2 changes: 1 addition & 1 deletion runtime/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ sp-consensus-grandpa = { default-features = false, git = "https://github.com/par
sp-core = { default-features = false, git = "https://github.com/paritytech/polkadot-sdk.git", rev = "cdf107de700388a52a17b2fb852c98420c78278e" }
sp-genesis-builder = { default-features = false, git = "https://github.com/paritytech/polkadot-sdk.git", rev = "cdf107de700388a52a17b2fb852c98420c78278e" }
sp-inherents = { default-features = false, git = "https://github.com/paritytech/polkadot-sdk.git", rev = "cdf107de700388a52a17b2fb852c98420c78278e" }
sp-io = { default-features = false, git = "https://github.com/paritytech/polkadot-sdk.git", rev = "cdf107de700388a52a17b2fb852c98420c78278e" }
sp-io = { default-features = false, git = "https://github.com/paritytech/polkadot-sdk.git", rev = "cdf107de700388a52a17b2fb852c98420c78278e", features = ["disable_panic_handler"] }
sp-offchain = { default-features = false, git = "https://github.com/paritytech/polkadot-sdk.git", rev = "cdf107de700388a52a17b2fb852c98420c78278e" }
sp-runtime = { default-features = false, git = "https://github.com/paritytech/polkadot-sdk.git", rev = "cdf107de700388a52a17b2fb852c98420c78278e" }
sp-session = { default-features = false, git = "https://github.com/paritytech/polkadot-sdk.git", rev = "cdf107de700388a52a17b2fb852c98420c78278e" }
Expand Down
1 change: 1 addition & 0 deletions runtime/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ pub use sp_runtime::{Perbill, Permill};

mod bridge_config;
mod genesis_config_presets;
mod panic_handler;
mod weights;
mod xcm_config;

Expand Down
14 changes: 14 additions & 0 deletions runtime/src/panic_handler.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
//! Panic handler for builds without `std`.

// TODO: Remove this file once `sp-io` is upgraded.
// See https://github.com/paritytech/polkadot-bulletin-chain/issues/18.

use sp_core::LogLevel;

#[cfg(not(feature = "std"))]
#[panic_handler]
pub fn panic(info: &core::panic::PanicInfo) -> ! {
let message = alloc::format!("{}", info);
sp_io::logging::log(LogLevel::Error, "runtime", message.as_bytes());
unreachable!();
}
Loading