-
Notifications
You must be signed in to change notification settings - Fork 6
Fixed smoldot westend integration test #170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The CI fails because of a timeout, my local run is stuck on |
…zombienet nodes with --listen-addr for WebSocket (port+1) Converted TCP bootnodes to WebSocket in smoldot script automatically Removed continue-on-error from CI now that smoldot parachain works
|
@x3c41a after your WS magic :) the authorize is finalized and store just waits to be included in the block: https://github.com/paritytech/polkadot-bulletin-chain/actions/runs/20950357905/job/60202260127?pr=170#step:12:151 maybe few things to try:
|
33bfe7a to
a9e328b
Compare
|
Reverted to the previous version, |
…ometimes become unavailable
| if (tcpMatch) { | ||
| const [, hostPart, portStr, peerId] = tcpMatch; | ||
| const tcpPort = parseInt(portStr, 10); | ||
| const wsPort = tcpPort + 1; // Convention: WS port = TCP port + 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a convention that lives as a code comment here and in zombienet/bulletin-westend-local.toml implicitly.
Maybe it's worth extracting this convention somewhere? But where? @bkontur
| p2p_port = 30333 | ||
| rpc_port = 9942 | ||
| balance = 2000000000000 | ||
| # WebSocket P2P on p2p_port + 1 for smoldot light client support |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comments to be moved or removed
bkontur
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@x3c41a thank you, nice one, please just remove bulletin-westend-spec.json file and we can merge
I also thought that it was redundant but it actually contains account balance overwrites which allow Alice (IIRC) to sign and send/spend the transaction. Otherwise |
|
May I merge? @bkontur |
that file is generated by |
|
Ahhh, I see. I simplified that script too |
|
Fixes #172 |
Key Fixes
Smoldot Bootnode Issue
convertBootNodeToWebSocket()that converts TCPmultiaddrsto WebSocket format using conventionws_port = tcp_port + 1. Zombienet nodes configured with--listen-addr /ip4/0.0.0.0/tcp/{port+1}/wsTransaction Indexing
TransactionStoragepallet,cumulus-pallet-parachain-system = { features = ["transaction-index"], workspace = true }@bkontur
CI apt-get 403 Errors
403 ForbiddenOther Changes