Optimised CI #182
Merged
Optimised CI #182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
x3c41a
commented
Jan 16, 2026
bkontur
reviewed
Jan 16, 2026
examples/justfile
Outdated
|
|
||
| # Start all services for a runtime (use with run-test-* recipes) | ||
| # Usage: just start-services bulletin-polkadot-runtime | ||
| start-services runtime: npm-install |
Collaborator
There was a problem hiding this comment.
I would add test_dir as param
Suggested change
| start-services runtime: npm-install | |
| start-services test_dir runtime: npm-install |
x3c41a
commented
Jan 16, 2026
Contributor
Author
There was a problem hiding this comment.
JFYI
After this PR I have a feeling that it's high time to refactor justfile - #185
bkontur
reviewed
Jan 17, 2026
examples/justfile
Outdated
Comment on lines
368
to
369
| # File to store current test directory path for multi-test runs | ||
| _test-dir-file := "/tmp/bulletin-test-dir" |
Collaborator
There was a problem hiding this comment.
Let's use test_dir propagation - it is safer then to make expectation about current dir or -f checks
Suggested change
| # File to store current test directory path for multi-test runs | |
| _test-dir-file := "/tmp/bulletin-test-dir" |
bkontur
reviewed
Jan 17, 2026
bkontur
reviewed
Jan 17, 2026
Closed
bkontur
reviewed
Jan 20, 2026
x3c41a
commented
Jan 20, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another attempt on a fresh master (no merge conflicts this time)