Validate unsigned -> pallet::authorize #194
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
@antkve please rebase/merge with main |
antkve
force-pushed
the
ak-validate-unsigned
branch
from
c4a0588 to
e7af58e
Compare
antkve
force-pushed
the
ak-validate-unsigned
branch
from
e7af58e to
42a690a
Compare
Contributor
Author
Done. By the way I'm not sure if we want to keep backwards compatibility like in the frame system upgrade? Can add that back in. |
bkontur
reviewed
Jan 22, 2026
| pub fn store(_origin: OriginFor<T>, data: Vec<u8>) -> DispatchResult { | ||
| #[pallet::authorize(|_source, data| { | ||
| Pallet::<T>::to_validity_with_refund( | ||
| Pallet::<T>::check_unsigned_store(data.as_slice(), CheckContext::Validate), |
Collaborator
There was a problem hiding this comment.
@antkve Could we just use here PreDispatch flow, which modifies authorizations and remove all the is_authorized handling from the call?
Suggested change
| Pallet::<T>::check_unsigned_store(data.as_slice(), CheckContext::Validate), | |
| Pallet::<T>::check_unsigned_store(data.as_slice(), CheckContext::PreDispatch), |
Collaborator
|
@antkve please, check this fmt and fix compilation |
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO
authorize_preimageand ProvideCidCodec andsp_io::hashing::blake2_256(data)incheck_unsigned