-
Notifications
You must be signed in to change notification settings - Fork 6
Review bulletin westend's xcm config #195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Wait for finalized block when authorizing accounts to ensure authorization is confirmed before proceeding with storage operations. Co-Authored-By: Claude Opus 4.5 <[email protected]>
bkontur
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@franciscoaguirre thank you :)
cc: @rosarp @x3c41a Let's wait with merge for fresh weights for bulletin-westend.
And later (for bulletin-polkadot) we should add integration test for reserve-transfer: #195
|
@bkontur We have a convention that any parachain with id < 2000 is a system parachain. Even though Bulletin doesn't accept teleports it is still a system parachain because of its id (1006) but also because it's tightly integrated in the system. |
@franciscoaguirre yes, good point, you're right. For Westend we have
|
The integration tests require WASM binaries for westend-runtime and asset-hub-westend-runtime. Override SKIP_WASM_BUILD=0 specifically for the integration test step. Co-Authored-By: Claude Opus 4.5 <[email protected]>
|
Specifying westend-runtime as a direct dependency is necessary even if we're not importing anything from it since we need it for correctly propagating the runtime-benchmarks and try-runtime features |
Locally, it worked for me without I suspect this: https://github.com/paritytech/polkadot-bulletin-chain/pull/195/files#diff-55f05888fd854d9962bdd4d8ccf23a07b610990f58174397b2586b58f8937428R116 |
aha, you're right, I see, |
@franciscoaguirre nice, thank you, everything works now, and also thank you for that integration test 🚀 |
|
@bkontur We're only missing running the weights on a specific VM now |
Addresses part of #168
TODO