-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[Staking] Async Election and Export #10311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/cmd fmt |
|
/cmd prdoc --force |
|
All GitHub workflows were cancelled due to failure one of the required jobs. |
|
Created backport PR for
Please cherry-pick the changes locally and resolve any conflicts. git fetch origin backport-10311-to-unstable2507
git worktree add --checkout .worktree/backport-10311-to-unstable2507 backport-10311-to-unstable2507
cd .worktree/backport-10311-to-unstable2507
git reset --hard HEAD^
git cherry-pick -x 90b7cafd8cfba509cc0f6ea476acc1a8c9ad0c11
git push --force-with-lease |
|
Created backport PR for
Please cherry-pick the changes locally and resolve any conflicts. git fetch origin backport-10311-to-stable2509
git worktree add --checkout .worktree/backport-10311-to-stable2509 backport-10311-to-stable2509
cd .worktree/backport-10311-to-stable2509
git reset --hard HEAD^
git cherry-pick -x 90b7cafd8cfba509cc0f6ea476acc1a8c9ad0c11
git push --force-with-lease |
|
Created backport PR for
Please cherry-pick the changes locally and resolve any conflicts. git fetch origin backport-10311-to-stable2512
git worktree add --checkout .worktree/backport-10311-to-stable2512 backport-10311-to-stable2512
cd .worktree/backport-10311-to-stable2512
git reset --hard HEAD^
git cherry-pick -x 90b7cafd8cfba509cc0f6ea476acc1a8c9ad0c11
git push --force-with-lease |
Backport #10311 into `stable2509` from Ank4n. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> --------- Co-authored-by: Ankan <[email protected]> Co-authored-by: Ankan <[email protected]> Co-authored-by: Egor_P <[email protected]>
Backport #10311 into `stable2512` from Ank4n. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> --------- Co-authored-by: Ankan <[email protected]> Co-authored-by: Ankan <[email protected]> Co-authored-by: Egor_P <[email protected]>
…10526) Backport #10311 into `unstable2507` from Ank4n. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> --------- Co-authored-by: Ankan <[email protected]> Co-authored-by: Ankan <[email protected]> Co-authored-by: BDevParity <[email protected]>
closes #10142
Context
Era rotation in
pallet-staking-asynccoordinates validator set changes between Asset Hub and Relay Chain. Currently:Happy Era Lifecycle (On Polkadot):
Issue with current approach
These issues are currently unlikely, but with elastic scaling (multiple cores in AH), they become more probable.
Solution
Result
This ensures we send elected validators for the next era always at the right time. It also has two good side effects:
Note for Reviewers
Open Questions
TODO
PlanningEraOffsetandValidatorSetExportSession, demonstrating same outcome except election timings.DocumentationUpdate:
I have removed the new storage
LastEraActivationSessionReportEndingIndexand instead rely only on session index from staking. I guess there is some tiny bit value in creating this new storage since:– this pallet already knows everything it needs to know via session reports,
– keeping its logic lean and self-contained, without adding a dependency on the staking pallet.
But the pallets already talk via
AHStakingInterfaceand so I don't think above reason holds.