fatxpool: metrics for unfiltered timings of inblock events #10312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/cmd prdoc --bump minor --audience node_dev |
…-audience node_dev'
|
All GitHub workflows were cancelled due to failure one of the required jobs. |
skunert
approved these changes
Nov 14, 2025
| )?, | ||
| registry, | ||
| )?, | ||
| in_block2: register( |
Contributor
There was a problem hiding this comment.
Can we pls not call it in_block2? :D
WDYT about in_block_duplicates or in_block_nonexclusive. Also shitty, but at least ives an idea.
Contributor
Author
There was a problem hiding this comment.
in_block2 was a good name :)
changed to in_block_forks in aa6806c
iulianbarbu
approved these changes
Nov 17, 2025
michalkucharczyk
deleted the
mku-non-filtered-in-block-timings-metrics
branch
michalkucharczyk
added
the
A4-backport-stable2512
paritytech-release-backport-bot bot
pushed a commit
that referenced
this pull request
Jan 21, 2026
This PR adds a new experimental metric `substrate_sub_txpool_timing_event_in_block2` for the reliability dashboard. Unlike the existing `in_block` metric which records timing only for the first `InBlock` event per transaction, the new `in_block2` metric records every InBlock event without filtering. This allows tracking transactions that appear in multiple blocks during chain reorganizations, providing better visibility into fork-related transaction behavior. The implementation adds the new histogram to `EventsHistograms` and updates `handle_status()` to record unfiltered InBlock events before applying deduplication logic. This approach should allow for experimenting with new _inblock confidence_ metric, without affecting the data currently shown on the Reliability Dashboard. --------- Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com> (cherry picked from commit acd0306)
|
Successfully created backport PR for |
EgorPopelyaev
pushed a commit
that referenced
this pull request
Jan 21, 2026
Backport #10312 into `stable2512` from michalkucharczyk. See the [documentation](https://github.com/paritytech/polkadot-sdk/blob/master/docs/BACKPORT.md) on how to use this bot. <!-- # To be used by other automation, do not modify: original-pr-number: #${pull_number} --> Co-authored-by: Michal Kucharczyk <[email protected]> Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new experimental metric
substrate_sub_txpool_timing_event_in_block2for the reliability dashboard. Unlike the existingin_blockmetric which records timing only for the firstInBlockevent per transaction, the newin_block2metric records every InBlock event without filtering. This allows tracking transactions that appear in multiple blocks during chain reorganizations, providing better visibility into fork-related transaction behavior. The implementation adds the new histogram toEventsHistogramsand updateshandle_status()to record unfiltered InBlock events before applying deduplication logic.This approach should allow for experimenting with new inblock confidence metric, without affecting the data currently shown on the Reliability Dashboard.